Messages in this thread | | | Date | Sat, 1 Jun 2013 10:11:31 -0700 | Subject | Re: [PATCH] efi, pstore: Cocci spatch "memdup.spatch" | From | Kees Cook <> |
| |
On Sat, Jun 1, 2013 at 2:40 AM, Thomas Meyer <thomas@m3y3r.de> wrote: > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Acked-by: Kees Cook <keescook@chromium.org>
Thanks!
-Kees
> --- > > diff -u -p a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c > --- a/drivers/firmware/efi/efi-pstore.c > +++ b/drivers/firmware/efi/efi-pstore.c > @@ -79,10 +79,9 @@ static int efi_pstore_read_func(struct e > &entry->var.DataSize, entry->var.Data); > size = entry->var.DataSize; > > - *cb_data->buf = kmalloc(size, GFP_KERNEL); > + *cb_data->buf = kmemdup(entry->var.Data, size, GFP_KERNEL); > if (*cb_data->buf == NULL) > return -ENOMEM; > - memcpy(*cb_data->buf, entry->var.Data, size); > return size; > } > > > >
-- Kees Cook Chrome OS Security
| |