lkml.org 
[lkml]   [2013]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [SCSI] libsas: Cocci spatch "ptr_ret.spatch"
From
Date
On Sat, 2013-06-01 at 11:59 +0200, Thomas Meyer wrote:
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -1093,9 +1093,7 @@ int sas_init_queue(struct sas_ha_struct
>
> core->queue_thread = kthread_run(sas_queue_thread, sas_ha,
> "sas_queue_%d", core->shost->host_no);
> - if (IS_ERR(core->queue_thread))
> - return PTR_ERR(core->queue_thread);
> - return 0;
> + return PTR_RET(core->queue_thread);
> }

Really, no, this is not a good patch. I know exactly what the current
code is doing by reading it. With your patch I now have to go and look
up the definition of an obscure and non-standard macro.

If we're sacrificing clarity, I want a good reason and having two lines
fewer code isn't it.

James




\
 
 \ /
  Last update: 2013-06-01 18:21    [W:0.030 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site