Messages in this thread | | | Date | Fri, 31 May 2013 21:00:46 -0700 | From | Olof Johansson <> | Subject | Re: [PATCH 2/3] ARM: SAMSUNG: Consolidate uncompress subroutine |
| |
On Fri, May 31, 2013 at 05:19:03PM +0530, Tushar Behera wrote: > For mach-exynos, uart_base is a pointer and the value is calculated > in the machine folder. For other machines, uart_base is defined as > a macro in platform directory. For symmetry, the uart_base macro > definition is removed and the uart_base calculation is moved to > specific machine folders. > > This would help us consolidating uncompress subroutine for s5p64x0.
Sorry, reading these in order and didn't go through all of them.
Same comment here, you can use config_enabled() and return early instead of adding ifdefs.
-Olof
| |