Messages in this thread | | | Date | Thu, 9 May 2013 13:11:08 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v2] kernel: audit_tree: resource management: need put_tree and goto Err when failure occures |
| |
On Thu, 09 May 2013 20:53:06 +0800 Chen Gang <gang.chen@asianux.com> wrote:
> get_tree() in audit_add_tree_rule() is needed (my original conclusion is incorrect).
OK..
> But we need let 'rule->tree = NULL;' firstly, so can protect rule itself freed in kill_rules().
I'll believe you ;) I turned this into a proper patch and added your (missed) Signed-off-by:.
> For me, after 'rule->tree = NULL', all things seems fine !!
Well, what was wrong before? Is there some user-triggerable misbehaviour which you observed? If so, please describe it.
| |