lkml.org 
[lkml]   [2013]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND 1/4] usb: ehci-s5p: fix memleak when devm_usb_get_phy fail
On Thu, 9 May 2013, Libo Chen wrote:

> When devm_usb_get_phy fail, we should free hcd
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
> drivers/usb/host/ehci-s5p.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
> index 6357752..3fbab58 100644
> --- a/drivers/usb/host/ehci-s5p.c
> +++ b/drivers/usb/host/ehci-s5p.c
> @@ -107,6 +107,7 @@ static int s5p_ehci_probe(struct platform_device *pdev)
> if (IS_ERR(phy)) {
> /* Fallback to pdata */
> if (!pdata) {
> + usb_put_hcd(hcd);
> dev_warn(&pdev->dev, "no platform data or transceiver defined\n");
> return -EPROBE_DEFER;
> } else {

Acked-by: Alan Stern <stern@rowland.harvard.edu>



\
 
 \ /
  Last update: 2013-05-09 22:41    [W:0.059 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site