Messages in this thread | | | Date | Wed, 08 May 2013 13:24:24 +0800 | From | Gao feng <> | Subject | Re: [PATCH RFC 10/48] Audit: change type of audit_ever_enabled to bool |
| |
On 05/08/2013 10:06 AM, Matt Helsley wrote: > On Tue, May 07, 2013 at 10:20:31AM +0800, Gao feng wrote: >> It's better to define audit_ever_enabled as bool >> >> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com> >> --- >> kernel/audit.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/audit.c b/kernel/audit.c >> index 4595a9e..1138ff5 100644 >> --- a/kernel/audit.c >> +++ b/kernel/audit.c >> @@ -76,7 +76,7 @@ static int audit_initialized; >> #define AUDIT_OFF 0 >> #define AUDIT_ON 1 >> #define AUDIT_LOCKED 2 >> -int audit_ever_enabled; >> +bool audit_ever_enabled; > > I think you're better off placing this at the beginning of the series > and submitting it separately since it's only incidentally related to > this RFC. >
Thanks for your suggestion. will send these cleanup patches separately.
Thanks Gao
| |