lkml.org 
[lkml]   [2013]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: of_mdio: fix behavior on missing phy device
Hello.

On 07-05-2013 13:49, Sebastian Hesselbarth wrote:

> of_mdiobus_register creates a phy_device even if get_phy_device failed
> to create it previously. This causes indefinite polling on non-existent
> PHYs. This fix makes of_mdio_register rely on get_phy_device to
> properly create the device or fail otherwise.

> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: David Miller <davem@davemloft.net>
> Cc: devicetree-discuss@lists.ozlabs.org
> Cc: linux-kernel@vger.kernel.org
> Cc: netdev@vger.kernel.org
> ---
> drivers/of/of_mdio.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)

> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 23049ae..d5a57a9 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -84,13 +84,10 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
> phy = get_phy_device(mdio, addr, is_c45);
>

This empty line is not needed -- would be good to drop it, while at
this.

> if (!phy || IS_ERR(phy)) {
> - phy = phy_device_create(mdio, addr, 0, false, NULL);
> - if (!phy || IS_ERR(phy)) {
> - dev_err(&mdio->dev,
> - "error creating PHY at address %i\n",
> - addr);
> - continue;
> - }
> + dev_err(&mdio->dev,
> + "cannot get PHY at address %i\n",
> + addr);
> + continue;
> }
>
> /* Associate the OF node with the device structure so it
>



\
 
 \ /
  Last update: 2013-05-07 20:41    [W:0.254 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site