Messages in this thread | | | Date | Tue, 7 May 2013 20:58:19 +0500 | Subject | Re: [PATCH] x86, setup: Removed spaces, trailing character and suspect code indent warnings and errors in a20.c This is a patch to the a20.c file that fixes following warnings/errors found by the checkpatch.pl tool i) WARNING: please, no spaces at the st | From | Syed Salman Mansoor <> |
| |
Thanks a lot. I am trying again. Hopefully this will work :)
On Tue, May 7, 2013 at 6:50 PM, Borislav Petkov <bp@alien8.de> wrote: > On Tue, May 07, 2013 at 06:20:22PM +0500, Syed Salman Mansoor wrote: >> Signed-off-by: Syed Salman Mansoor <syed.salman.mansoor@gmail.com> > > No, > > this is still wrong: > > Subject: [PATCH] x86, setup: Removed spaces, trailing character and suspect code indent warnings and errors in a20.c This is a patch to the a20.c file that > fixes following warnings/errors found by the checkpatch.pl tool i) WARNING: please, no spaces at the start of a line ii) WARNING: suspect code > indent for conditional statements iii) ERROR: trailing whitespace > > Don't you think that this Subject line is insanely long but the patch > still doesn't have a commit message? > > I can see you're using git so when you do: > > git commit -a -s > > and the editor opens, simply type in a short name for the patch into the > first line: > > "x86, boot: Cleanup A20 code" > > or something which hints at what this patch does. > > Then, do a newline and on the third line, type in the rest of the > subject above: > >> Remove spaces, trailing character and suspect code indent warnings and >> errors in a20.c This is a patch to the a20.c file that fixes following > > You don't have to say which file it patches since we can see that from > the diffstat. > >> warnings/errors found by the checkpatch.pl tool i) WARNING: please, >> no spaces at the start of a line ii) WARNING: suspect code indent for >> conditional statements iii) ERROR: trailing whitespace > > So basically do something like that: > > "Fix checkpatch.pl warnings in a20.c: > i) blabla > ii) more blabla > iii) and so on blabla" > > Btw, Documentation/SubmittingPatches is a good document to read. :-) > > Thanks. > > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > --
| |