Messages in this thread | | | Date | Tue, 7 May 2013 17:35:25 +0200 | From | Stanislaw Gruszka <> | Subject | Re: Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3 |
| |
On Tue, May 07, 2013 at 03:53:30PM +0200, Johannes Berg wrote: > > > I think the best way to solve this would be to do such a thing in > > > iwlegacy as well, but until then and for stable maybe we should > > > introduce another HW flag to restore the previous mac80211 behaviour? > > > > I'm not sure if I like to add passive_no_rx to iwlegacy. Stopping queues > > and waiting for beacon looks sticky, what happen if beacon will not be > > received? > > Good question, do we get stuck? I was assuming we'd time out, but maybe > that's not the case?
AFICT, we wake queues only if beacon arrives or mac80211 call drv_config with BSS_CHANGED_IDLE. I'm not sure if the latter prevent stuck.
> > Perhaps I will just remove IEEE80211_HW_REPORTS_TX_ACK_STATUS from 4965, > > it's simpler workaround ? > > Sure, but maybe that loses other semantics that you want? > > And anyway it's not complete. If you have a very long beacon interval > (say 1 second) then this could still lead to all probe/auth retries > going out inbetween two beacons since the timeout is just 3*100ms.
Let's make that change as temporary regression workaround, I'll add passive_no_rx workaround latter. I'll also think if it can stuck or not.
Stanislaw
| |