lkml.org 
[lkml]   [2013]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 33/33] blk-throttle: implement proper hierarchy support
    On Mon, May 06, 2013 at 03:46:12PM -0700, Tejun Heo wrote:
    > With the recent updates, blk-throttle is finally ready for proper
    > hierarchy support. Dispatching now honors service_queue->parent_sq
    > and propagates correctly. The only thing missing is setting
    > ->parent_sq correctly so that throtl_grp hierarchy matches the cgroup
    > hierarchy.
    >
    > This patch updates throtl_pd_init() such that service_queues form the
    > same hierarchy as the cgroup hierarchy if sane_behavior is enabled.
    > As this concludes proper hierarchy support for blkcg, the shameful
    > .broken_hierarchy tag is removed from blkio_subsys.
    >
    > Signed-off-by: Tejun Heo <tj@kernel.org>
    > Cc: Li Zefan <lizefan@huawei.com>
    > ---
    > block/blk-cgroup.c | 8 --------
    > block/blk-throttle.c | 22 +++++++++++++++++++++-
    > include/linux/cgroup.h | 2 ++
    > 3 files changed, 23 insertions(+), 9 deletions(-)
    >
    > diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
    > index af2ca27..8d9edc8 100644
    > --- a/block/blk-cgroup.c
    > +++ b/block/blk-cgroup.c
    > @@ -911,14 +911,6 @@ struct cgroup_subsys blkio_subsys = {
    > .subsys_id = blkio_subsys_id,
    > .base_cftypes = blkcg_files,
    > .module = THIS_MODULE,
    > -
    > - /*
    > - * blkio subsystem is utterly broken in terms of hierarchy support.
    > - * It treats all cgroups equally regardless of where they're
    > - * located in the hierarchy - all cgroups are treated as if they're
    > - * right below the root. Fix it and remove the following.
    > - */
    > - .broken_hierarchy = true,

    So if somebody does not specify __DEVEL_sane_behavior, hierarchy is
    still broken. Should we continue to display the message in that case?

    Vivek


    \
     
     \ /
      Last update: 2013-05-07 16:45    [W:4.083 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site