lkml.org 
[lkml]   [2013]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Add missing module license tag to vring helpers.
Date
Dave Jones <davej@redhat.com> writes:
> [ 624.286653] vringh: module license 'unspecified' taints kernel.
>
> Signed-off-by: Dave Jones <davej@redhat.com>

Thanks! This is exactly right.

But note that the default license tag for otherwise-unlabelled modules
would be "GPLv2". "GPL" means v2 or later (which is what I want, but
it's not the kernel default).

Applied,
Rusty.

> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
> index bff0775..5174eba 100644
> --- a/drivers/vhost/vringh.c
> +++ b/drivers/vhost/vringh.c
> @@ -3,6 +3,7 @@
> *
> * Since these may be in userspace, we use (inline) accessors.
> */
> +#include <linux/module.h>
> #include <linux/vringh.h>
> #include <linux/virtio_ring.h>
> #include <linux/kernel.h>
> @@ -1005,3 +1006,5 @@ int vringh_need_notify_kern(struct vringh *vrh)
> return __vringh_need_notify(vrh, getu16_kern);
> }
> EXPORT_SYMBOL(vringh_need_notify_kern);
> +
> +MODULE_LICENSE("GPL");


\
 
 \ /
  Last update: 2013-05-06 10:21    [W:0.036 / U:3.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site