Messages in this thread | | | Date | Mon, 6 May 2013 10:27:47 +0300 | Subject | Re: [linux-next-20130422] Bug in SLAB? | From | Pekka Enberg <> |
| |
On Mon, May 6, 2013 at 9:59 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Fri, May 3, 2013 at 5:43 PM, Christoph Lameter <cl@linux.com> wrote: >> Subject: slab: Return NULL for oversized allocations >> >> The inline path seems to have changed the SLAB behavior for very large >> kmalloc allocations. This patch restores the old behavior but also >> adds diagnostics so that we can figure where in the code these >> large allocations occur. >> >> Signed-off-by: Christoph Lameter <cl@linux.com> >> >> >> Index: linux/include/linux/slab_def.h >> =================================================================== >> --- linux.orig/include/linux/slab_def.h 2013-05-03 10:36:46.019564801 -0500 >> +++ linux/include/linux/slab_def.h 2013-05-03 10:37:28.860302188 -0500 >> @@ -126,6 +126,11 @@ static __always_inline void *kmalloc(siz >> if (!size) >> return ZERO_SIZE_PTR; >> >> + if (size > KMALLOC_MAX_SIZE) { >> + WARN_ON(1); > > As we were worried about this being triggered frm userspace, this needs > some rate limiting, to avoid flooding the kernel logs.
I changed it to WARN_ON_ONCE():
https://git.kernel.org/cgit/linux/kernel/git/penberg/linux.git/commit/?h=slab/next
| |