Messages in this thread | | | Date | Mon, 6 May 2013 13:33:30 -0700 | From | "" <> | Subject | Re: [PATCH v2] PM: Fix dev_pm_put_subsys_data() to not call kfree() while holding device power lock |
| |
On Mon, May 06, 2013 at 09:56:56PM +0200, Rafael J. Wysocki wrote: > On Monday, May 06, 2013 12:41:19 PM gregkh@linuxfoundation.org wrote: > > On Mon, May 06, 2013 at 07:04:53PM +0000, Shuah Khan wrote: > > > dev_pm_put_subsys_data() calls kfree() while holding device power lock, when > > > the reference count is 0. Fix it to call kfree() after releasing the lock. > > > > > > Signed-off-by: Shuah Khan <shuah.kh@samsung.com> > > > Reviewed-by: Pavel Machek <pavel@ucw.cz> > > > Reviewed-by: Rafael Wysocki <rafael.j.wysocki@intel.com> > > > --- > > > drivers/base/power/common.c | 8 +++++--- > > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > Is this causing a problem now, and it should go into 3.10 and earlier > > kernels (if so, which ones?), or can it just wait until 3.11 as it's > > just a cleanup fix? > > I think it's OK to push the fix for 3.10, but I'll take care of this (I have > a bunch of fixes for 3.10 anyway, but I'll send a pull request after -rc1, > because people are sending me fixes pretty much continuously ATM).
Ok, feel free to add:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| |