Messages in this thread | | | Date | Sat, 4 May 2013 08:37:38 +0200 | Subject | Re: [PATCH 1/2] rcu: Fix full dynticks' dependency on wide RCU nocb mode | From | Frederic Weisbecker <> |
| |
2013/5/3 Paul E. McKenney <paulmck@linux.vnet.ibm.com>: > On Fri, May 03, 2013 at 06:47:55PM +0200, Frederic Weisbecker wrote: >> Commit 0637e029392386e6996f5d6574aadccee8315efa >> ("nohz: Select wide RCU nocb for full dynticks") intended >> to force CONFIG_RCU_NOCB_CPU_ALL=y when full dynticks is >> enabled. >> >> However this option is part of a choice menu and Kconfig's >> "select" instruction has no effect on such targets. >> >> Fix this by using reverse dependencies on the targets we >> don't want instead. >> >> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> >> Cc: Christoph Lameter <cl@linux.com> >> Cc: Hakan Akkan <hakanakkan@gmail.com> >> Cc: Ingo Molnar <mingo@kernel.org> >> Cc: Kevin Hilman <khilman@linaro.org> >> Cc: Li Zhong <zhong@linux.vnet.ibm.com> >> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> >> Cc: Paul Gortmaker <paul.gortmaker@windriver.com> >> Cc: Peter Zijlstra <peterz@infradead.org> >> Cc: Steven Rostedt <rostedt@goodmis.org> >> Cc: Thomas Gleixner <tglx@linutronix.de> > > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Nice!
Ingo, if you haven't yet pulled, please rather pick the "timers/nohz-hz1-v2" branch that has the Reviewed-by: tag from Paul.
Thanks.
| |