Messages in this thread | | | Date | Sat, 4 May 2013 10:19:23 -0500 | From | Nishanth Menon <> | Subject | Re: [PATCH] regulator: ti-abb: Fix off-by-one valid range checking for abb->current_info_idx |
| |
Change in Liam's email ID. On 22:02-20130504, Axel Lin wrote: > abb->current_info_idx is used as array subscript to access volt_table, > thus the valid value range should be 0 ... desc->n_voltages - 1. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/regulator/ti-abb-regulator.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/regulator/ti-abb-regulator.c b/drivers/regulator/ti-abb-regulator.c > index c1870ea..870d209 100644 > --- a/drivers/regulator/ti-abb-regulator.c > +++ b/drivers/regulator/ti-abb-regulator.c > @@ -387,8 +387,8 @@ static int ti_abb_get_voltage_sel(struct regulator_dev *rdev) > return -EINVAL; > } > > - if (abb->current_info_idx > (int)desc->n_voltages) { > - dev_err(dev, "%s: Corrupted data? idx(%d) > n_voltages(%d)\n", > + if (abb->current_info_idx >= (int)desc->n_voltages) { > + dev_err(dev, "%s: Corrupted data? idx(%d) >= n_voltages(%d)\n", > __func__, abb->current_info_idx, desc->n_voltages); > return -EINVAL; > } > -- > 1.8.1.2
Thanks for the same. Acked-by: Nishanth Menon <nm@ti.com>
-- Regards, Nishanth Menon
| |