lkml.org 
[lkml]   [2013]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH, RFC 04/22] staging/drm: imx: add missing dependencies
On Fri, May 03, 2013 at 05:21:37PM +0200, Arnd Bergmann wrote:
> On Friday 03 May 2013, Shawn Guo wrote:
> > On Thu, May 02, 2013 at 05:16:08PM +0200, Arnd Bergmann wrote:
> > > The imx DRM driver needs a couple of extra Kconfig dependencies
> > > to avoid random build failures:
> > >
> > > drivers/staging/imx-drm/ipuv3-crtc.c:448:
> > > undefined reference to `ipu_idmac_put'
> > > drivers/staging/imx-drm/ipuv3-crtc.c:450: undefined reference to
> > > `ipu_dmfc_put' drivers/staging/imx-drm/ipuv3-crtc.c:452:
> > > undefined reference to `ipu_dp_put'
> > > drivers/staging/imx-drm/ipuv3-crtc.c:454: undefined reference to
> > > `ipu_di_put'
> > > drivers/built-in.o: In function `ipu_probe':
> > > :(.text+0x4b4174): undefined reference to `device_reset'
> > > drivers/built-in.o: In function `imx_tve_probe':
> > > drivers/staging/imx-drm/imx-tve.c:648: undefined reference to
> > > `devm_regmap_init_mmio_clk'
> > > drivers/built-in.o: In function
> > > `imx_pd_connector_get_modes':
> >
> > > drivers/staging/imx-drm/parallel-display.c:78: undefined
> > > reference to `of_get_drm_display_mode'
> >
> > There is a patch [1] from Marek fixing this one.
> >
> > Shawn
> >
> > [1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/233449
> >
>
> That patch only addresses one of the four missing dependencies.
> I originally had four separate patches, but did not want to
> bother everyone with those so I combined them into one.

Yea, I agree we can address all of them in one patch. But it seems
people agreed that there is a more correct way [1] to fix
of_get_drm_display_mode one, and that's how v2 of Marek's patch comes.

Shawn

[1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/232861/focus=232898



\
 
 \ /
  Last update: 2013-05-04 14:41    [W:0.068 / U:1.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site