Messages in this thread | | | Date | Sat, 01 Jun 2013 00:27:30 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH] usb: musb: Fix format specifier warning |
| |
Hello.
On 06/01/2013 12:22 AM, Emil Goode wrote:
> This patch fixes a format specifier warning. dma_addr_t can be either > u32 or u64 so we should cast to the largest type and change the format > specifier to %llx. > The addition of urb->transfer_dma and urb->actual_length is also done a > few lines below. I have moved this code up and pass the variable buf to > dev_dbg. > > Sparse output: > drivers/usb/musb/musb_host.c:1761:4: warning: > format ‘%x’ expects argument of type ‘unsigned int’, > but argument 6 has type ‘dma_addr_t’ [-Wformat] > > Signed-off-by: Emil Goode <emilgoode@gmail.com> > --- > drivers/usb/musb/musb_host.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c > index 094cf80..d647ccb 100644 > --- a/drivers/usb/musb/musb_host.c > +++ b/drivers/usb/musb/musb_host.c [...] > @@ -1789,11 +1789,8 @@ void musb_host_rx(struct musb *musb, u8 epnum) > length = rx_count; > d->status = d_status; > buf = urb->transfer_dma + d->offset; > - } else { > + } else
You should keep {} on the *else* branch since *if* branch has {}, according to Documentation/CodingStyle.
> length = rx_count; > - buf = urb->transfer_dma + > - urb->actual_length; > - }
WBR, Sergei
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |