Messages in this thread | | | From | Prabhakar Lad <> | Date | Fri, 31 May 2013 12:20:39 +0530 | Subject | Re: [PATCH 2/2] rtc: omap: add rtc wakeup support to alarm events |
| |
Hi Gururaja,
Thanks for the patch.
On Fri, May 31, 2013 at 12:03 PM, Hebbar Gururaja <gururaja.hebbar@ti.com> wrote: > On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN) [snip] > - ti,wakeup_capable: Inform the rtc driver that this module is wake-up > capable so that rtcwake and suspend tests can work. > +- ti,has_irq_wake_enb: Inform rtc driver that this module has a a same comment applies here as well. s/has a a/ has a
> + special register to enable Wakeup feature for Alarm events. > > Example: > > diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c > index 000a02f..5e9c0dd 100644 > --- a/drivers/rtc/rtc-omap.c > +++ b/drivers/rtc/rtc-omap.c > @@ -72,6 +72,8 @@ > #define OMAP_RTC_KICK0_REG 0x6c > #define OMAP_RTC_KICK1_REG 0x70 > > +#define OMAP_RTC_IRQWAKEEN 0x7C > + why not have the hex values in smaller case as done in the rest of the file ?
Regards, --Prabhakar Lad
| |