Messages in this thread Patch in this message | | | Date | Fri, 31 May 2013 04:46:04 -0700 | From | tip-bot for Jiri Olsa <> | Subject | [tip:perf/core] perf hists: Rename hist_entry__add_pair arguments |
| |
Commit-ID: 4d23322a0b8d0f40819dc02ea15a732a78b0a1c0 Gitweb: http://git.kernel.org/tip/4d23322a0b8d0f40819dc02ea15a732a78b0a1c0 Author: Jiri Olsa <jolsa@redhat.com> AuthorDate: Thu, 13 Dec 2012 14:09:00 +0100 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Tue, 28 May 2013 16:24:02 +0300
perf hists: Rename hist_entry__add_pair arguments
The current logic is to attach pair to the leader hist_entry.
Arguments of hist_entry__add_pair function were placed the other way round.. driving me crazy.
I.e. list_add_tail expects (new_node, head).
Signed-off-by: Jiri Olsa <jolsa@redhat.com> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1355404152-16523-3-git-send-email-jolsa@redhat.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/sort.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h index 51f1b5a..45ac84c 100644 --- a/tools/perf/util/sort.h +++ b/tools/perf/util/sort.h @@ -117,10 +117,10 @@ static inline struct hist_entry *hist_entry__next_pair(struct hist_entry *he) return NULL; } -static inline void hist_entry__add_pair(struct hist_entry *he, - struct hist_entry *pair) +static inline void hist_entry__add_pair(struct hist_entry *pair, + struct hist_entry *he) { - list_add_tail(&he->pairs.head, &pair->pairs.node); + list_add_tail(&pair->pairs.node, &he->pairs.head); } enum sort_mode {
| |