Messages in this thread | | | Date | Thu, 30 May 2013 16:10:54 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] arm: Prevent memory aliasing on non-LPAE kernels |
| |
On Thu, May 30, 2013 at 02:45:20PM -0700, Stepan Moskovchenko wrote: > void __init early_init_dt_add_memory_arch(u64 base, u64 size) > { > +#ifndef CONFIG_ARM_LPAE > + if (base > ((phys_addr_t)~0)) {
The #ifdef is probably not necessary here, simply checking that base/size can be represented in a phys_addr_t is enough.
> + pr_crit("Ignoring memory at 0x%08llx due to lack of LPAE support\n", > + base); > + return; > + } > + > + if (size > ((phys_addr_t)~0)) > + size = ((phys_addr_t)~0);
A similar printk as arm_add_memory for this one too?
printk(KERN_CRIT "Truncating memory at 0x%08llx to fit in " "32-bit physical address space\n", (long long)start);
Regards, Jason
| |