lkml.org 
[lkml]   [2013]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] arm: Prevent memory aliasing on non-LPAE kernels
    On Thu, May 30, 2013 at 02:45:20PM -0700, Stepan Moskovchenko wrote:
    > void __init early_init_dt_add_memory_arch(u64 base, u64 size)
    > {
    > +#ifndef CONFIG_ARM_LPAE
    > + if (base > ((phys_addr_t)~0)) {

    The #ifdef is probably not necessary here, simply checking that
    base/size can be represented in a phys_addr_t is enough.

    > + pr_crit("Ignoring memory at 0x%08llx due to lack of LPAE support\n",
    > + base);
    > + return;
    > + }
    > +
    > + if (size > ((phys_addr_t)~0))
    > + size = ((phys_addr_t)~0);

    A similar printk as arm_add_memory for this one too?

    printk(KERN_CRIT "Truncating memory at 0x%08llx to fit in "
    "32-bit physical address space\n", (long long)start);

    Regards,
    Jason


    \
     
     \ /
      Last update: 2013-05-31 00:21    [W:3.568 / U:0.720 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site