Messages in this thread | | | Date | Thu, 30 May 2013 20:48:03 +0200 | From | Lars-Peter Clausen <> | Subject | Re: [PATCH v2 6/6] MIPS: jz4740: Remove custom DMA API |
| |
On 05/30/2013 07:20 PM, Vinod Koul wrote: > On Thu, May 30, 2013 at 06:25:05PM +0200, Lars-Peter Clausen wrote: >> Now that all users of the custom jz4740 DMA API have been converted to use >> the dmaengine API instead we can remove the custom API and move all the code >> talking to the hardware to the dmaengine driver. >> >> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> >> Acked-by: Ralf Baechle <ralf@linux-mips.org> >> --- >> No changes since v1 >> --- >> arch/mips/include/asm/mach-jz4740/dma.h | 56 ------ >> arch/mips/jz4740/Makefile | 2 +- >> arch/mips/jz4740/dma.c | 307 -------------------------------- >> drivers/dma/dma-jz4740.c | 258 +++++++++++++++++++++++---- >> 4 files changed, 222 insertions(+), 401 deletions(-) >> delete mode 100644 arch/mips/jz4740/dma.c > only dma.c, you should remove the dma.h or relocate it to linux/
As I said the header only contains the slave ids at this point and the dmaengine driver doesn't need it anymore. So I should remove the #include from the driver as well.
> > > rest of the series looks fine, and once we have acks from repsective subsystem > mainatiners, we should be good to merge
We already have acks from the maintainers.
- Lars
| |