lkml.org 
[lkml]   [2013]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Improving or replacing snd_printk()
On Wed, 29 May 2013, Joe Perches wrote:

> On Wed, 2013-05-29 at 15:27 -0400, Alan Stern wrote:
> > Has there been any thought of improving snd_printk(), or even better,
> > changing the call sites to use the dev_*() routines instead?
>
> Perhaps better would be to add and use some combination of
> type specific logging message functions/macros like:
>
> void snd_<level>(const struct snd_device *dev, const char *fmt, ...)
> void snd_card_<level>(const struct snd_card *card, const char *fmt, ...)
> void snd_ac97_<level>(const struct snd_ac97 *ac97, const char *fmt, ...)
>
> allowing NULL as the type pointer when necessary/appropriate.

Almost anything would be better than the current situation. The only
enhancement provided by CONFIG_SND_VERBOSE_PRINTK is to print the
filename and line number, which is relatively unhelpful (unless there
are multiple copies of the same message in several places).

Alan Stern



\
 
 \ /
  Last update: 2013-05-30 21:01    [W:0.096 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site