Messages in this thread | | | Date | Thu, 30 May 2013 12:09:48 +0300 | Subject | Re: [PATCH] cris: kgdb: use native hex2bin | From | Andy Shevchenko <> |
| |
On Thu, May 30, 2013 at 10:57 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Tue, May 28, 2013 at 5:53 PM, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: >> diff --git a/arch/cris/arch-v10/kernel/kgdb.c b/arch/cris/arch-v10/kernel/kgdb.c >> index 37e6d2c..07bccd8 100644 >> --- a/arch/cris/arch-v10/kernel/kgdb.c >> +++ b/arch/cris/arch-v10/kernel/kgdb.c > >> @@ -659,18 +651,6 @@ read_register (char regno, unsigned int *valptr) >> } >> >> /********************************** Packet I/O ******************************/ >> -/* Returns the integer equivalent of a hexadecimal character. */ >> -static int >> -hex (char ch) >> -{ >> - if ((ch >= 'a') && (ch <= 'f')) >> - return (ch - 'a' + 10); >> - if ((ch >= '0') && (ch <= '9')) >> - return (ch - '0'); >> - if ((ch >= 'A') && (ch <= 'F')) >> - return (ch - 'A' + 10); >> - return (-1); >> -} > > This one handles both upper and lower case hex characters, while hex2bin() > handles lower case only. Is that OK, or should hex2bin be extended?
Its implementation is located in lib/hexdump.c If you look at it carefully you find that hex2bin calls hex_to_bin() which services both cases (via using tolower()).
-- With Best Regards, Andy Shevchenko
| |