Messages in this thread | | | Date | Fri, 3 May 2013 22:41:51 +0200 | Subject | Re: [PATCH 21/63] dmaengine: ste_dma40: Don't configure runtime configurable setup during allocate | From | Linus Walleij <> |
| |
On Fri, May 3, 2013 at 4:32 PM, Lee Jones <lee.jones@linaro.org> wrote:
> Using the dmaengine API, allocating and configuring a channel are two > separate actions. Here we're removing logical channel configuration from > the channel allocating routines. > > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: Dan Williams <djbw@fb.com> > Cc: Per Forlin <per.forlin@stericsson.com> > Cc: Rabin Vincent <rabin@rab.in> > Signed-off-by: Lee Jones <lee.jones@linaro.org> (...)
> @@ -2024,6 +2024,9 @@ static int d40_config_memcpy(struct d40_chan *d40c) > d40c->dma_cfg = dma40_memcpy_conf_log; > d40c->dma_cfg.dev_type = dma40_memcpy_channels[d40c->chan.chan_id]; > > + d40_log_cfg(&d40c->dma_cfg, > + &d40c->log_def.lcsp1, &d40c->log_def.lcsp3); > +
So it only gets configured for memcpy now?
What happens if you use a logical channel for a device transfer?
Where will that be configured?
Have you tested this combo?
Yours, Linus Walleij
| |