lkml.org 
[lkml]   [2013]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] powerpc: Make Book E watchdog reset type configurable


Am 03.05.2013 15:46, schrieb Guenter Roeck:
> On Fri, May 03, 2013 at 10:33:13AM +0200, Dirk Eibach wrote:
>> Hi Guenter,
>>
>>>>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>>>>>> index e89fc31..6048593 100644
>>>>>> --- a/drivers/watchdog/Kconfig
>>>>>> +++ b/drivers/watchdog/Kconfig
>>>>>> @@ -1172,6 +1172,38 @@ config BOOKE_WDT_DEFAULT_TIMEOUT
>>>>>>
>>>>>> The value can be overridden by the wdt_period command-line
>>>>>> parameter.
>>>>>>
>>>>>> +choice
>>>>>> + prompt "PowerPC Book-E Watchdog reset type"
>>>>>> + depends on BOOKE_WDT
>>>>>> + default BOOKE_WDT_RESET_CHIP
>>>>>> + help
>>>>>> + Specify what kind of reset will be executed on watchdog
>>>>>> timeout.
>>>>>> +
>>>>> Seems to me it would be much better to make this configurable via
>>>>> platform data
>>>>> and/or device tree.
>>>>
>>>> good catch. What do the device-tree gurus think to be a nice
>>>> property name?
>>
>> having a closer look, I realized booke_wdt is not device-tree based
>> yet. Migrating it would come close to a rewrite, breaking
>> compatibility for all current users. Sorry, this is way beyond the
>
> Really ? I don't think making it a platform driver would be that hard,
> or break anything.

Maybe I am missing something, but wouldn't making it a device-tree
driver mean, that I would have to identify all users of BOOKE_WDT and
add it to their device trees?

Cheers
Dirk


\
 
 \ /
  Last update: 2013-05-03 20:41    [W:1.589 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site