Messages in this thread | | | Date | Fri, 3 May 2013 15:52:23 +0200 | From | Anatolij Gustschin <> | Subject | Re: [PATCH 1/1] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory |
| |
Hello Alexander,
On Fri, 3 May 2013 14:43:23 +0400 Alexander Popov <a13xp0p0v88@gmail.com> wrote:
> Hello Anatolij, > > > Note that there is a patch for .device_prep_slave_sg() operation > > for this driver as part of this series: > > https://patchwork.kernel.org/patch/2368581/ > > https://patchwork.kernel.org/patch/2368591/ > Thanks, I haven't seen that patch. > It's certainly what my SCLPC device driver needs > (http://patchwork.ozlabs.org/patch/241010/). > I will send the second version of it which uses .device_prep_slave_sg(). > > > maybe you can reuse and improve it. > > Anatolij > Should I propose my additions at https://patchwork.kernel.org/patch/2368591/ ?
Yes, I think so. I only used drivers new .device_prep_slave_sg() for SDHC DMA channel transfers up to now. Adding support for other peripherals would be good. With generic DMA DT bindings patch for this driver you can use
dmas = <&dma0 26>; dma-names = "rx-tx";
in your sclpc@10100 DT node and then dma_request_slave_channel(&pdev->dev, "rx-tx") in the lpbfifo driver.
Thanks,
Anatolij
| |