lkml.org 
[lkml]   [2013]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] minix: bug widening a binary "not" operation
On Thu, 16 May 2013 10:51:49 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:

> "chunk_size" is an unsigned int and "pos" is an unsigned long. The
> "& ~(chunk_size-1)" operation clears the high 32 bits unintentionally.
>
> The ALIGN() macro does the correct thing.
>
> ...
>
> @@ -95,7 +95,7 @@ static int minix_readdir(struct file * filp, void * dirent, filldir_t filldir)
> char *name;
> __u32 inumber;
>
> - pos = (pos + chunk_size-1) & ~(chunk_size-1);
> + pos = ALIGN(pos, chunk_size);
> if (pos >= inode->i_size)
> goto done;
>

I'm suspecting there aren't many minix filesystems out there with a >4G
directory ;)

But we should fix it to set a good example, and to quieten
whatever-tool-i-suspect-you-were-using(?).


\
 
 \ /
  Last update: 2013-05-30 01:21    [W:0.039 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site