Messages in this thread | | | Date | Wed, 29 May 2013 14:59:33 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE |
| |
On Fri, 24 May 2013 19:39:25 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
> audit_log_start() does wait_for_auditd() in a loop until > audit_backlog_wait_time passes or audit_skb_queue has a room. > > If signal_pending() is true this becomes a busy-wait loop, > schedule() in TASK_INTERRUPTIBLE won't block.
And that's game over for a uniprocessor non-preempt machine, yes?
> Reported-by: Guy Streeter <streeter@redhat.com>
And what did Guy report? "that looks screwy"? "my machine locked up"?
> @@ -1056,7 +1056,7 @@ static inline void audit_get_stamp(struc > static void wait_for_auditd(unsigned long sleep_time) > { > DECLARE_WAITQUEUE(wait, current); > - set_current_state(TASK_INTERRUPTIBLE); > + set_current_state(TASK_UNINTERRUPTIBLE); > add_wait_queue(&audit_backlog_wait, &wait); > > if (audit_backlog_limit &&
| |