lkml.org 
[lkml]   [2013]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE
On Fri, 24 May 2013 19:39:25 +0200 Oleg Nesterov <oleg@redhat.com> wrote:

> audit_log_start() does wait_for_auditd() in a loop until
> audit_backlog_wait_time passes or audit_skb_queue has a room.
>
> If signal_pending() is true this becomes a busy-wait loop,
> schedule() in TASK_INTERRUPTIBLE won't block.

And that's game over for a uniprocessor non-preempt machine, yes?

> Reported-by: Guy Streeter <streeter@redhat.com>

And what did Guy report? "that looks screwy"? "my machine locked up"?

> @@ -1056,7 +1056,7 @@ static inline void audit_get_stamp(struc
> static void wait_for_auditd(unsigned long sleep_time)
> {
> DECLARE_WAITQUEUE(wait, current);
> - set_current_state(TASK_INTERRUPTIBLE);
> + set_current_state(TASK_UNINTERRUPTIBLE);
> add_wait_queue(&audit_backlog_wait, &wait);
>
> if (audit_backlog_limit &&


\
 
 \ /
  Last update: 2013-05-30 00:21    [W:0.051 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site