lkml.org 
[lkml]   [2013]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/4] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c
> > > > > +void xen_setup_runstate_info(int cpu)
> > > > > +{
> > > > > + struct vcpu_register_runstate_memory_area area;
> > > > > +
> > > > > + area.addr.v = &per_cpu(xen_runstate, cpu);
> > > > > +
> > > > > + if (HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area,
> > > > > + cpu, &area))
> > > > > + BUG();
> > > >
> > > > The original code did:
> > > >
> > > > - rc = HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area, cpu,
> > > > - &area);
> > > > - WARN_ON(rc && rc != -ENOSYS);
> > > > -
> > > > Any reason not to do this?
> > >
> > > The original x86 code just BUGs out: I took that version over the ia64
> > > version.
> >
> > Ah, I see it now. OK, then this looks good to me.
> >
>
> Can I add your acked-by? ;-)

How about?

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>


\
 
 \ /
  Last update: 2013-05-29 20:21    [W:2.174 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site