Messages in this thread | | | Date | Wed, 29 May 2013 09:18:39 -0700 | From | Sören Brinkmann <> | Subject | Re: [PATCH 1/3] video: xilinxfb: Fix OF probing on little-endian systems |
| |
On Wed, May 29, 2013 at 06:12:56PM +0200, Michal Simek wrote: > From: Michal Simek <monstr@monstr.eu> > > DTB is always big-endian that's why is necessary > to convert it. > > Signed-off-by: Michal Simek <monstr@monstr.eu> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > drivers/video/xilinxfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c > index af0b4fd..5af341e 100644 > --- a/drivers/video/xilinxfb.c > +++ b/drivers/video/xilinxfb.c > @@ -428,7 +428,7 @@ static int xilinxfb_of_probe(struct platform_device *op) > * interface and initialize the tft_access accordingly. > */ > p = (u32 *)of_get_property(op->dev.of_node, "xlnx,dcr-splb-slave-if", NULL); You should consider using 'of_property_read_u32() (or one of its other variants for arrays, strings, etc). That already implicitly does the endian conversion.
Sören
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |