Messages in this thread | | | From | "Cherian, George" <> | Subject | RE: [PATCH 3/3] usb: dwc3: omap Modify dwc3_omap_readl/writel with offsets | Date | Wed, 29 May 2013 06:54:04 +0000 |
| |
> -----Original Message----- > From: Balbi, Felipe > Sent: Tuesday, May 28, 2013 11:02 PM > To: Cherian, George > Cc: Balbi, Felipe; linux-usb@vger.kernel.org; linux-omap@vger.kernel.org; > linux-kernel@vger.kernel.org; gregkh@linuxfoundation.org > Subject: Re: [PATCH 3/3] usb: dwc3: omap Modify dwc3_omap_readl/writel > with offsets > > Hi, > > On Mon, May 27, 2013 at 01:32:57PM +0530, George Cherian wrote: > > This patch modifies dwc3_omap_readl/writel calls to accomodate > > both OMAP5 and AM437x reg maps (It uses the cached register offsets). > > Also renames OMAP5 IRQ1 as IRQMISC, IRQ1 bits as IRQMISC bits. > > > > Signed-off-by: George Cherian <george.cherian@ti.com> > > can you change this patch a bit so that it adds wrappers around > dwc3_omap_*() ? The idea is the have the code look like: > > static u32 dwc3_omap_read_utmi_status(struct dwc3_omap *omap) > { > return dwc3_omap_readl(omap->base, > USBOTGSS_UTMI_OTG_STATUS + > omap->utmi_otg_offset); > } > > (likewise for write and for all other offsets, of course) > > that way, reading/writing to registers which need the offset will be > less error-prone and th driver will look a little nicer.
Yes , I will do it in next version. > > -- > Balbi -George
| |