Messages in this thread | | | Date | Wed, 29 May 2013 16:52:49 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 2/4] ARM: u8540: Add device tree support for lp5521 leds |
| |
On Wed, 29 May 2013, Gabriel Fernandez wrote:
> From: Gabriel Fernandez <gabriel.fernandez@st.com> > > This patch adds DT probing of lp5521 leds for u8540. > > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@stericsson.com> > --- > arch/arm/boot/dts/ccu8540-uib-v3.dts | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/ccu8540-uib-v3.dts b/arch/arm/boot/dts/ccu8540-uib-v3.dts > index 4b4982e..422a292 100644 > --- a/arch/arm/boot/dts/ccu8540-uib-v3.dts > +++ b/arch/arm/boot/dts/ccu8540-uib-v3.dts > @@ -14,3 +14,25 @@ > / { > model = "ST-Ericsson U8540 platform with device tree UIB v3"; > }; > + > +&i2c2 {
I'm really not a fan of this syntax.
I only see it lending itself to more abstraction and obfuscation.
> + > + lp5521@32 { > + compatible = "national,lp5521"; > + reg = <0x32>; > + label = "lp5521_pri"; > + clock-mode = /bits/ 8 <2>; > + chan0 { > + led-cur = /bits/ 8 <0x2f>; > + max-cur = /bits/ 8 <0x5f>; > + }; > + chan1 { > + led-cur = /bits/ 8 <0x2f>; > + max-cur = /bits/ 8 <0x5f>; > + }; > + chan2 { > + led-cur = /bits/ 8 <0x2f>; > + max-cur = /bits/ 8 <0x5f>; > + }; > + }; > +};
More odd tabbing above.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |