lkml.org 
[lkml]   [2013]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH 2/2] x86/xen: sync the wallclock when the system time changes
On 29/05/13 08:47, Jan Beulich wrote:
>>>> On 28.05.13 at 20:22, David Vrabel <david.vrabel@citrix.com> wrote:
>> @@ -199,28 +201,59 @@ static void xen_get_wallclock(struct timespec *now)
>>
>> static int xen_set_wallclock(const struct timespec *now)
>> {
>> - struct xen_platform_op op;
>> - int ret;
>> -
>> /* do nothing for domU */
>> if (!xen_initial_domain())
>> return -1;
>>
>> - /* Set the Xen wallclock. */
>> + /* Set the hardware RTC. */
>> + return mach_set_rtc_mmss(now);
>> +
>> +}
>
> Can't you achieve the same effect in a cleaner way by overriding
> x86_platform.set_wallclock only in the non-init-domain case?

Yes, that makes sense. John, don't apply this one yet, thanks.

David


\
 
 \ /
  Last update: 2013-05-29 12:21    [W:0.164 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site