lkml.org 
[lkml]   [2013]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Patch for thinkpad-acpi.c
Hi, Bjorn

Thank your advice .
I will modify my code, then try to submit again.

Bruce.Ma
May 29,2013


On 05/28/2013 06:28 PM, Bjørn Mork wrote:
> Bruce <bruce.ma@canonical.com> writes:
>
>> +struct blacklist lenovo_blacklist[] = {
>> + {
>> + .model_s = "Lenovo LM490s",
>> + .nummodel_s = "814YG01",
>> + },
>
> The driver already has a list of LED support per model in the
>
> static const struct tpacpi_quirk led_useful_qtable[] __initconst = {}
>
> array. Why do you duplicate this with lots of new model checking code
> instead of just using the code that's already there?
>
>> static void led_exit(void)
>> {
>> + if (no_led == 1 ) {
>
> The driver already has provisions for signalling that LEDs are
> unsupported through the 'led_supported' variable. Why do you add
> another variable, and duplicate testing in every access function?
>
> But I don't think this part is needed at all, as long as you set up the
> proper LED map in led_useful_qtable.
>
>
>
> Bjørn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-05-29 06:21    [W:0.047 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site