lkml.org 
[lkml]   [2013]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] drivers/tpm: add xen tpmfront interface
On Tue, May 28, 2013 at 11:40:32AM -0400, Daniel De Graaf wrote:
> This is a complete rewrite of the Xen TPM frontend driver, taking
> advantage of a simplified frontend/backend interface and adding support
> for cancellation and timeouts. The backend for this driver is provided
> by a vTPM stub domain using the interface in Xen 4.3.
>
> Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> Acked-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>

.. snip..
> +static void ring_free(struct tpm_private *priv)
> +{
> + if (!priv)
> + return;
> +
> + if (priv->ring_ref)
> + gnttab_end_foreign_access(priv->ring_ref, 0,
> + (unsigned long)priv->shr);
> + else
> + free_page((unsigned long)priv->shr);
> +
> + if (priv->chip && priv->chip->vendor.irq)
> + unbind_from_irqhandler(priv->chip->vendor.irq, priv);

You are missing:

if (priv->evtchn != INVALID_EVTCHN)
xenbus_free_evtchn(priv->xdev, priv->evtchn);

> +
> + kfree(priv);
> +}
> +


\
 
 \ /
  Last update: 2013-05-28 23:01    [W:1.558 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site