Messages in this thread | | | Date | Tue, 28 May 2013 12:09:14 -0700 | From | John Stultz <> | Subject | Re: [Xen-devel] [PATCH 2/3] timekeeping: sync persistent clock and RTC on system time step changes |
| |
On 05/28/2013 11:31 AM, Konrad Rzeszutek Wilk wrote: > On Tue, May 28, 2013 at 07:26:14PM +0100, David Vrabel wrote: >> On 15/05/13 19:10, John Stultz wrote: >>> Ok, so really, as soon as the Dom0 time is set by NTP, all guests will >>> see the right time? That makes more sense, and means the window for >>> these sorts of issues is reasonably quite small. >> It's a small window but it's occurring in our automated test system. >> >>> David: So I'm less inclined to merge this individual change, but if you >>> still feel strongly about it, let me know and we can circle around on it >>> after you've addressed the specific issues I pointed out earlier. >> This patch was the actual bug fix but I've reworked it to use the >> pvclock_gtod notifier chain as this seemed to be what KVM hosts were >> using to maintain a clock for guests. Please review the new series, thanks. > Looks good. > > John if you are OK I am thinking to push this to Linus shortly as it is > fixing a bug.
I'm really not sure I'd call this a bug. That seems like an over-reaction to a misconfigured system.
Or if there is a bug, I'm not sure its been clearly explained.
thanks -john
| |