Messages in this thread | | | Date | Tue, 28 May 2013 20:41:56 +0800 | From | Libo Chen <> | Subject | Re: [PATCH v2] usb: omap2430: fix memleak in err case |
| |
ping...
On 2013/5/22 11:30, Libo Chen wrote: > > when omap_get_control_dev faild, we should release related platform_device > > * Changelog from v1: > * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei <sergei.shtylyov@cogentembedded.com> > > Signed-off-by: Libo Chen <libo.chen@huawei.com> > --- > drivers/usb/musb/omap2430.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c > index 3551f1a..b626f19 100644 > --- a/drivers/usb/musb/omap2430.c > +++ b/drivers/usb/musb/omap2430.c > @@ -549,7 +549,8 @@ static int omap2430_probe(struct platform_device *pdev) > glue->control_otghs = omap_get_control_dev(); > if (IS_ERR(glue->control_otghs)) { > dev_vdbg(&pdev->dev, "Failed to get control device\n"); > - return -ENODEV; > + ret = -ENODEV; > + goto err2; > } > } else { > glue->control_otghs = ERR_PTR(-ENODEV); >
| |