Messages in this thread | | | Date | Tue, 28 May 2013 11:05:22 +0100 | From | Chris Wilson <> | Subject | Re: [PATCH -next] drm/i915: fix error return code in init_pipe_control() |
| |
On Tue, May 28, 2013 at 05:51:44PM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fix to return -ENOMEM in the kmap() error handling case > instead of 0, as done elsewhere in this function.
kmap() can fail?
It is either translated to page_address() or kmap_high() (on x86), neither of which may return NULL. However, only kmap_atomic() is documented as being guaranteed to return a valid value. If we could have a similar definitive statement for kmap(), we can then cleanup quite a bit of redundant error handling. -Chris
-- Chris Wilson, Intel Open Source Technology Centre
| |