lkml.org 
[lkml]   [2013]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] regulator: 88pm800: add regulator driver
From
HI, Brown:

2013/5/26 Mark Brown <broonie@kernel.org>:
> On Fri, May 24, 2013 at 11:01:45AM +0800, yi zhang wrote:
>> 2013/5/23 Mark Brown <broonie@kernel.org>:
>> > On Wed, May 22, 2013 at 08:10:53PM +0800, yizhang.mrvl@gmail.com wrote:
>
>> >> +static const unsigned int BUCK1_table[] = {
>> >> + /* 0x00-0x4F: from 0.6 to 1.5875V with step 0.0125V */
>> >> + /* 0x50-0x7F: from 1.6 to 1.8V with step 0.05V */
>
>> > Write this out as code, don't use a big table for large sets of
>> > voltages.
>
>> The voltage table is "const", if we write it out as code, seems
>> it's hard for us
>> to keep this attribute;
>> And the voltage of this BUCK is not linear(it's separated as two parts),
>> seems I shouldn't use the framework helpers to implement it; Right?
>> what do you think?
>
> You should open code the mapping functions but you should still do this
> as calcuations, it's faster and produces smaller code. You'll need a
> small function with an if statement.
Sorry I'm a little confused:
You mean I should use a function for example
"create_buck_table()" to create the BUCK voltage table?
such as:
void create_buck_table()
{
if (voltage < 1587500) {
/* initialize the BUCK_table */
} else
/* initialize the BUCK_table */
}

thanks;


\
 
 \ /
  Last update: 2013-05-28 05:21    [W:2.256 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site