lkml.org 
[lkml]   [2013]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] modules: insert mods sorted
Date
Andrew Jones <drjones@redhat.com> writes:
> While there isn't a big difference between typing 'lsmod' and
> 'lsmod | sort', the module listing in Oopses isn't so easily sorted.
> Attempting to search these quickly by eye for particular modules while
> rapidly triaging bugs can be a pain. Sort the list and reduce the pain.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>

Hi Andrew,

ISTR the story of young Fleming being fired as bottlewasher for
a major lab because the head researcher felt he was wasting his
talents.[1]

Please take my rejection of this patch as similar endorsement of
your future prospects.

Cheers,
Rusty.
[1] Google can't find any trace of this story, so may be my imagination...

> ---
> kernel/module.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index cab4bce49c23d..7914d8ef2e09c 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -3146,7 +3146,7 @@ static int may_init_module(void)
> static int add_unformed_module(struct module *mod)
> {
> int err;
> - struct module *old;
> + struct module *old, *m;
>
> mod->state = MODULE_STATE_UNFORMED;
>
> @@ -3166,7 +3166,13 @@ again:
> err = -EEXIST;
> goto out;
> }
> - list_add_rcu(&mod->list, &modules);
> + if (!list_empty(&modules)) {
> + list_for_each_entry(m, &modules, list)
> + if (strcmp(mod->name, m->name) < 0)
> + break;
> + list_add_tail_rcu(&mod->list, &m->list);
> + } else
> + list_add_rcu(&mod->list, &modules);
> err = 0;
>
> out:
> --
> 1.8.1.4


\
 
 \ /
  Last update: 2013-05-28 01:21    [W:0.065 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site