Messages in this thread | | | Date | Sun, 26 May 2013 12:12:44 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH 2/6] gpu: host1x: Fix syncpoint wait return value |
| |
On Fri, May 17, 2013 at 02:49:44PM +0300, Arto Merilainen wrote: > Syncpoint wait returned EAGAIN if it was called with zero timeout. > This patch modifies the function to return ETIMEDOUT.
This description is a bit redundant, because it repeats in prose what the code does. I'd rather see a description of why the change is necessary.
Thinking about it, maybe it would be good to have two separate error codes. Keeping -EAGAIN for the case where a zero timeout was passed doesn't sound too bad to differentiate it from the case where a non- zero timeout was passed and it actually timed out. What do you think?
Thierry [unhandled content-type:application/pgp-signature] | |