lkml.org 
[lkml]   [2013]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arch: blackfin: kernel: using strlcpy instead of strncpy
On 05/26/2013 03:04 PM, Chen Gang wrote:
>
> For NULL terminated string, need always be sure of ended by zero.
>
> 'command_line' is a static variable which will be initialized
> automatically, and cmdline_init() is __init function, so need not
> initialize it again, can just use strlcpy instead of strncpy.
>

The 2nd paragraph comment is redundent, need delete. I will send patch v2.

>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/blackfin/kernel/setup.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c
> index 107b306..c731ec7 100644
> --- a/arch/blackfin/kernel/setup.c
> +++ b/arch/blackfin/kernel/setup.c
> @@ -1458,5 +1458,5 @@ void __init cmdline_init(const char *r0)
> {
> early_shadow_stamp();
> if (r0)
> - strncpy(command_line, r0, COMMAND_LINE_SIZE);
> + strlcpy(command_line, r0, COMMAND_LINE_SIZE);
> }
>


--
Chen Gang

Asianux Corporation


\
 
 \ /
  Last update: 2013-05-27 04:21    [W:1.050 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site