Messages in this thread | | | Date | Sun, 26 May 2013 18:02:54 -0400 | From | KOSAKI Motohiro <> | Subject | Re: [patch v2 3/6] mm/memory_hotplug: Disable memory hotremove for 32bit |
| |
(5/26/13 2:09 PM), Michal Hocko wrote: > On Sun 26-05-13 07:58:42, KOSAKI Motohiro wrote: >>>> As KOSAKI Motohiro mentioned, memory hotplug don't support 32bit since >>>> it was born, >>> >>> Why? any reference? This reasoning is really weak. >> >> I have no seen any highmem support in memory hotplug code and I don't think this >> patch fixes all 32bit highmem issue. If anybody are interesting to >> support it, it is good thing. But in fact, _now_ it is broken when >> enable HIGHMEM. >> So, I just want to mark broken until someone want to support highmem >> and verify overall. >> >> And, yes, this patch is no good. Kconfig doesn't describe why disable >> when highmem. >> So, >> >> depends on 64BIT || !HIGHMEM || BROKEN >> >> maybe clear documentation more. > > I have no objection to disbale the feature for HIGHMEM configurations I > was merely complaining that the patch didn't describe _why_.
No worry. I withdrew the claim because several people now willing to contribute 32bit highmem improvement. I don't want to block them.
| |