Messages in this thread | | | From | (Eric W. Biederman) | Date | Fri, 24 May 2013 20:01:36 -0700 | Subject | Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390 |
| |
Zhang Yanfei <zhangyanfei.yes@gmail.com> writes:
> Hello Eric, > >> The function copy_oldmem_page also concerns me. I don't have a clue why >> we duplicate that function on every architecutre in a slightly different >> form. There should be enough abstractions in the kernel to make that >> unnecessary. I would be glad to see that function go, and remove the >> possibility of confusion that happened on s390. > > You mean we should have a common copy_oldmem_page for all architectures? And > just like vivek said above, for s390, we should put the swap info in the elf > headers instead of doing that in copy_oldmem_page.
Exactly.
The user space change in /sbin/kexec should even be backwards compatible for s390. So fixing /sbin/kexec should probably come first.
Eric
| |