lkml.org 
[lkml]   [2013]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] mm/kmemleak.c: Merge the consecutive scan-areas.
On Tue, May 14, 2013 at 12:49:51PM +0100, majianpeng wrote:
> If the scan-areas are adjacent,it can merge in order to reduce memomy.

Have you found any significant reduction in the memory size?

What we miss though is removing an area (and I found a use-case for it).

> + hlist_for_each_entry(area, &object->area_list, node) {
> + if (ptr + size == area->start) {
> + area->start = ptr;
> + area->size += size;
> + goto out_unlock;
> + } else if (ptr == area->start + area->size) {
> + area->size += size;
> + goto out_unlock;

I prefer to keep 'goto' only for the error path. You could add a 'bool
merged' and another 'if' block for area allocation.

I'll pick the other too patches.

Thanks.

--
Catalin


\
 
 \ /
  Last update: 2013-05-24 19:41    [W:0.028 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site