lkml.org 
[lkml]   [2013]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue
Hello.

On 24-05-2013 9:34, B, Ravi wrote:

>>>> removed unused nop xceiv (un_)register API's from all musb platform
>>>> drivers

>>> Since when are they unused?

>> Please refer to commit id 662dca54 : usb: otg: support for multiple transceivers by a single controller.
>> Usb_get_phy() is used to get the of phy used by controller, phy bindings are done through DT.

>> Why are you sure that all these platforms support DT (in all configurations)?
>> It seems to me that you're simply breaking the patched glue layers with this patch.
>> I'll let Felipe decide the fate of this patch though...

> You are correct, the bindings of phy and controller need not to done through DT alone, there is a saperate API
> Phy API's available for such bindings done in respective board platform files.

I don't see any such code in e.g. DaVinci/DA8xx platform files.

>>>> Signed-off-by: Ravi Babu <ravibabu@ti.com>
>> --
>> Ravi B

WBR, Sergei



\
 
 \ /
  Last update: 2013-05-24 17:21    [W:0.060 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site