Messages in this thread | | | Subject | Re: [PATCH 1/7] staging/silicom/bypasslib: Reformat comments | From | Joe Perches <> | Date | Thu, 23 May 2013 15:42:54 -0700 |
| |
On Thu, 2013-05-23 at 13:51 -0700, Lisa Nguyen wrote: > Resolved the C99 comment style issue by reformatting existing comments > to meet kernel coding standards in bp_ioctl.h [] > diff --git a/drivers/staging/silicom/bypasslib/bp_ioctl.h b/drivers/staging/silicom/bypasslib/bp_ioctl.h [] > -#define BP_CAP 0x01 //BIT_0 [...] > +#define BP_CAP 0x01 /* BIT_0 */
Better to use the more self-documenting
#define BP_CAP BIT(0)
etc... with out any comment at all.
| |