lkml.org 
[lkml]   [2013]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/7] staging/silicom/bypasslib: Reformat comments
From
Date
On Thu, 2013-05-23 at 13:51 -0700, Lisa Nguyen wrote:
> Resolved the C99 comment style issue by reformatting existing comments
> to meet kernel coding standards in bp_ioctl.h
[]
> diff --git a/drivers/staging/silicom/bypasslib/bp_ioctl.h b/drivers/staging/silicom/bypasslib/bp_ioctl.h
[]
> -#define BP_CAP 0x01 //BIT_0
[...]
> +#define BP_CAP 0x01 /* BIT_0 */

Better to use the more self-documenting

#define BP_CAP BIT(0)

etc... with out any comment at all.




\
 
 \ /
  Last update: 2013-05-24 01:21    [W:0.039 / U:2.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site