Messages in this thread | | | Date | Thu, 23 May 2013 13:15:30 -0400 | From | Dave Jones <> | Subject | Re: [PATCH 1/8] Documentation: Adding "The Perfect Patch" by Andrew Morton |
| |
On Thu, May 23, 2013 at 10:49:53PM +1000, Ben Minerds wrote: > +- Don't bother mentioning what version of the kernel the patch applies to > + ("applies to 2.6.8-rc1"). This is not interesting information - once the > + patch is in bitkeeper, of _course_ it applied, and it'll probably be merged > + into a later kernel than the one which you wrote it for. > + > +- Do not refer to earlier patches when changelogging a new version of a > + patch. It's not very useful to have a bitkeeper changelog which says "OK, > + this fixes the things you mentioned yesterday". Each iteration of the patch > + should contain a standalone changelog. This implies that you need a patch > + management system which maintains changelogs. See below.
s/bitkeeper/git/
> +- Make sure that your patches apply to the latest version of the kernel > + tree. Either straight from bitkeeper or from > + ftp://ftp.kernel.org/pub/linux/kernel/v2.6/snapshots/
ditto. (Also, update url)
Dave
| |