lkml.org 
[lkml]   [2013]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs
On Thu, May 23, 2013 at 12:01:11PM -0400, Jason Cooper wrote:
> > > + /* Kirkwood resets some registers on gated clocks. Especially
> > > + * CLK125_BYPASS_EN must be cleared but is not available on
> > > + * all other SoCs/System Controllers using this driver.
> > > + */
> > > + if (of_machine_is_compatible("marvell,kirkwood"))
> > > + wrlp(mp, PORT_SERIAL_CONTROL1,
> > > + rdlp(mp, PORT_SERIAL_CONTROL1) & ~CLK125_BYPASS_EN);
> >
> > of_machine_is_compatible seems heavy handed, I would expect this to be
> > based on the compatible string of the ethernet node itself, not the
> > machine??
>
> Is there a model number variation between IP that needs this and IP that
> doesn't? If not, I'm fine with of_machine_is_compatible().

Well the name 'mv643xx' is a family of system controller SOC's
from ages ago, it seems reasonble to continue the trend and label the
IP variations with the SOC name:

compatible = "marvell,kirwood,ethernet", "marvell,mv643xx_eth"

Jason


\
 
 \ /
  Last update: 2013-05-23 19:41    [W:0.117 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site