lkml.org 
[lkml]   [2013]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread
On 5/23/2013 8:58 AM, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> when there is an error from kthread_run, then return proper error
> rather than returning -ENOMEM.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
> fs/f2fs/gc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 25b083c..03d5ba1 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -105,7 +105,7 @@ int start_gc_thread(struct f2fs_sb_info *sbi)
> if (IS_ERR(gc_th->f2fs_gc_task)) {
> kfree(gc_th);

gc_th is free'd here, save off PTR_ERR result to avoid use-after-free?

> sbi->gc_thread = NULL;
> - return -ENOMEM;
> + return PTR_ERR(gc_th->f2fs_gc_task);
> }
> return 0;
> }
>

--
Jason Hrycay


\
 
 \ /
  Last update: 2013-05-23 17:01    [W:0.036 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site